[MERGE][0.14] Don't check plugins for tabs
John Arbash Meinel
john at arbash-meinel.com
Wed Jan 17 23:37:46 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Alexander Belchenko wrote:
> John Arbash Meinel ?8H5B:
>>> Etienne just posted this bug:
>>> And I noticed there are 2 bugs in selftest.
>>> 1) 'tools' only exists in the source tree
>>> 2) test_source.py is checking if plugins have tabs characters in the
>>> source. While I would recommend that they not avoid them, I don't think
>>> we should have tests failing in those circumstances. Attached is a patch
>>> which skips 'utils' and 'plugins', just like the copyright and gpl
>>> license tests.
> something wrong with your patch -- it seems that diff contains also
> fix for problems with annotate.
Yeah, I was planning on removing that part, and I forget. Ignore it, and
just focus on the following:
> === modified file 'bzrlib/tests/test_source.py'
> --- bzrlib/tests/test_source.py 2006-11-06 21:00:45 +0000
> +++ bzrlib/tests/test_source.py 2007-01-17 22:33:32 +0000
> @@ -258,6 +258,8 @@
> incorrect = 
> for fname, text in self.get_source_file_contents():
> + if '/util/' in fname or '/plugins/' in fname:
> + continue
> if '\t' in text:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar