[MERGE] Bugfix #55276: on win32 cat, bundle and diff commands provide binary output without mangling line-endings

Alexander Belchenko bialix at ukr.net
Tue Dec 19 11:31:17 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> Alexander Belchenko ?8H5B:
> 
> ....
> 
>> After inspecting attributes of all built-ins non-hidden command
>> I see that only 2 commands have exact encoding type: diff and version-info.
> 
>> I don't think that parsing output of version-info will be difficult
>> with CRLF line-endings, so I think this command don't require binary
>> stdout on win32.
> 
> 'cat' should definitely be "exact", I think I just didn't get that far
> when updating all of the commands.
> 
> Anything that outputs specific bytes should probably be 'exact'. So
> 'cat-revision' should be exact (and actually has a comment stating that).

I agree, 'cat-revision' should be 'exact' and produce valid utf-8 output.
Now it's encoded to be human-readable, so switching for 'exact'
require changes in generating output.
I think it's should be in another patch with corresponding tests.

Alexander

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFh82EzYr338mxwCURAoFwAJkBBiy6kqHhrZmo79BDjLYONOtIKQCfZy/U
AeiqrrOIsYaLSxu11g4roWs=
=xBin
-----END PGP SIGNATURE-----





More information about the bazaar mailing list