[BUG] bzr.dev connects multiple times while pushing

[Vincent Ladeuil]

>>>>> "jam" == John Arbash Meinel <john at arbash-meinel.com> writes:

    jam> I'm not sure why this is happening, but I was using 'bzr
    jam> push bzr+ssh://' to push something today, and I found
    jam> that bzr actually maed 4 connections to the remote
    jam> server. (This server prints a message when you connect,
    jam> and I see 4 of them).

    jam> It seems to just be a problem with bzr+ssh:// because if
    jam> I use bzr push sftp:// to the same machine, it only
    jam> connects one time.

I remember having encounter similar multiple connections with the
webdav plugin but didn't have time to track it down. But
definitely, there is a bug there.

    jam> Now, I realize that we have an "evil" connection cache
    jam> in the sftp implementation,

The HTTP one is not "evil" ;)

    jam> but connecting 4 times to push seems a little bit bad. I
    jam> don't really want to implement a connection cache, but
    jam> that is probably the easiest way to fix this. Any
    jam> thoughts?

I think a connection cache is not the right fix. Someone
convinced me on that subject some months ago.. Wait a minute, it
was you !  ;)

  Vincent