[MERGE] 'bzr selftest --clean' allows easily clean temporary tests directories

[Wouter van Heyst]

On Wed, Dec 13, 2006 at 09:35:36AM +0200, Alexander Belchenko wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> John Arbash Meinel пишет:
> > Alexander Belchenko wrote:
> >> After discussion about this change I personally don't think that
> >> bzrtools is *right* solution for me (personally), because not all system
> >> has bzrtools.
> >>
> >> I'd like to change 'make clean' to use cross-platform solution by using
> >> python scripts (something similar as I did for clean-docs).
> >>
> >> But anyway, why for clean all (that what 'make clean' do) when I want to
> >> clean only temp tests directories?
> > 
> > Well if you want cross platform 'make' isn't the best thing to be
> > writing it under. Since most Windows users won't have Make installed.
> 
> Agree.
> 
> > Again, I'm not strictly against selftest --clean, I just want to make
> > sure it is thought through.
> 
> OK. Here is additional arguments:
> 
> 1) selftest has option '--keep-output' to keep output directories when tests fail.
> New option '--clean' is complement to '--keep-output'. I think I could rename
> it to '--clean-output'. Thoughts?

I think the visual similarity would be good.

> 2) One can run selftest even for installed copy of bzr (after setup.py install)
> from any directory. Even from directory that does not contain sources of bzr.
> So in this case neither 'make clean' nor bzrtools' clean-tree won't help
> to remove selftest junk.
> 
> Result of discussion so far:
> 
> myself = +1
> Vincent = +1
> Wouter = +1 conditional (but I'm not sure how to write appropriate test)

I still have to learn the balancing act on testing, if you can't easily
write the test and the risk isn't that big (either left-over test dirs
are after clean or removal of non test dirs on explicitly supplied
argument), I guess we can go without.

> Aaron and John not strongly negative but not completely positive.
> So I'd like to count their opinion as 0 and 0 (without pluses).
> 
> I'd like to merge this patch because I think it will be useful.
> 
> So if Martin, Wouter (as our current release manager) or John or Aaron
> give me another strict +1 I'll merge it.

I think the change is useful and different enough to what we have. I do
in general fear tacking things on, instead of a clean designed system
that follows from first principles, in that respect I trust Aaron and
John.

Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061213/2cac4d5e/attachment.pgp