[MERGE] 'bzr selftest --clean' allows easily clean temporary tests directories

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> After discussion about this change I personally don't think that
>> bzrtools is *right* solution for me (personally), because not all system
>> has bzrtools.
>>
>> I'd like to change 'make clean' to use cross-platform solution by using
>> python scripts (something similar as I did for clean-docs).
>>
>> But anyway, why for clean all (that what 'make clean' do) when I want to
>> clean only temp tests directories?
> 
> Well if you want cross platform 'make' isn't the best thing to be
> writing it under. Since most Windows users won't have Make installed.

Agree.

> Again, I'm not strictly against selftest --clean, I just want to make
> sure it is thought through.

OK. Here is additional arguments:

1) selftest has option '--keep-output' to keep output directories when tests fail.
New option '--clean' is complement to '--keep-output'. I think I could rename
it to '--clean-output'. Thoughts?

2) One can run selftest even for installed copy of bzr (after setup.py install)
from any directory. Even from directory that does not contain sources of bzr.
So in this case neither 'make clean' nor bzrtools' clean-tree won't help
to remove selftest junk.

Result of discussion so far:

myself = +1
Vincent = +1
Wouter = +1 conditional (but I'm not sure how to write appropriate test)

Aaron and John not strongly negative but not completely positive.
So I'd like to count their opinion as 0 and 0 (without pluses).

I'd like to merge this patch because I think it will be useful.

So if Martin, Wouter (as our current release manager) or John or Aaron
give me another strict +1 I'll merge it.

Alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFf61HzYr338mxwCURAnPKAJ0U3gVlW7q5utkP9bPUpSBUeLsikwCfZsdN
rGKm9c7XhzvX5X5ipyVniro=
=S+G6
-----END PGP SIGNATURE-----