[BUG] bzr.dev connects multiple times while pushing

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm not sure why this is happening, but I was using 'bzr push
bzr+ssh://' to push something today, and I found that bzr actually maed
4 connections to the remote server. (This server prints a message when
you connect, and I see 4 of them).

It seems to just be a problem with bzr+ssh:// because if I use bzr push
sftp:// to the same machine, it only connects one time.

Now, I realize that we have an "evil" connection cache in the sftp
implementation, but connecting 4 times to push seems a little bit bad. I
don't really want to implement a connection cache, but that is probably
the easiest way to fix this. Any thoughts?

John
=:->

PS> I don't think this is a regression, as I would expect older versions
to do the same thing. I'm guessing get_transport() is being called from
multiple places, and is some cases that call is probably hidden.
(bzrlib.branch.Branch.open() will call it, for example).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFfxOgJdeBCYSNAAMRAgziAJ480PJRf9qplIdimcd35dK+lS3rFwCgw+x9
Mwon+OlW/N+usqXpaxE/yWk=
=7qqu
-----END PGP SIGNATURE-----