[MERGE] 'bzr selftest --clean' allows easily clean temporary tests directories

[Wouter van Heyst]

On Mon, Dec 11, 2006 at 05:31:04PM -0600, John Arbash Meinel wrote:
> Alexander Belchenko wrote:
> > Vincent Ladeuil ?8H5B:
> >>>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
> >>     bialix> This patch provide new flag to selftest command: --clean.
> >>     bialix> Run
> > 
> >>     bialix> bzr selftest --clean
> > 
> >>     bialix> to remove all testXXXX.tmp directories.
> > [...]
> >> +1 with updated help text
> > 
> >>     bialix> === modified file bzrlib/builtins.py
> >>     bialix> --- bzrlib/builtins.py
> >>     bialix> +++ bzrlib/builtins.py
> >>     bialix> @@ -2065,16 +2065,28 @@
> >>     bialix>                       Option('cache-dir', type=str,
> >>     bialix>                              help='a directory to cache intermediate'
> >>     bialix>                                   ' benchmark steps'),
> >>     bialix> +                     Option('clean',
> >>     bialix> +                            help='clean temporary tests directories'),
> >>     bialix>                       ]
> > 
> >> What about: 'clean temporary tests directories without running tests'
> > 
> > Thanks for suggestion. Here is updated patch.
> > 
> > Alexander
> > 
> 
> I'm not sure if 'selftest' is the right place to put something like this.
> 
> We do have 'bzr clean-tree' and 'bzr clean-tree --detritus' as part of
> bzrtools. 'bzr clean-tree --detritus' removes all of the .~1~ files, as
> well as the test directories.
> 
> I do understand the need for something. And maybe it is the most
> discoverable as an option to selftest.
> 
> But since this only really works as something for bzr itself, it seems
> like bzrtools already has a solution.
> 
> But if people like it enough, I won't stand in the way. I just wanted to
> voice a point of view.

When running the selftest with some error you can quickly accumulate a
bunch of test directories, being able ^Rselftest and tack on --clean to
get rid of them is conveniently fast. Not enough that I'll argue
strongly for it's inclusion. Personally I will have bzrtools installed,
and it's a developerish feature that I think doesn't need to be in core
bzr perse.

bzr clean-tree --detritus blows away a bit more than just the test
directories though, that would be biggest hurdle in my eyes.

Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061212/0ad0b936/attachment.pgp