[MERGE] 'bzr selftest --clean' allows easily clean temporary tests directories

[John Arbash Meinel]

Alexander Belchenko wrote:
> Vincent Ladeuil ?8H5B:
>>>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
>>     bialix> This patch provide new flag to selftest command: --clean.
>>     bialix> Run
> 
>>     bialix> bzr selftest --clean
> 
>>     bialix> to remove all testXXXX.tmp directories.
> [...]
>> +1 with updated help text
> 
>>     bialix> === modified file bzrlib/builtins.py
>>     bialix> --- bzrlib/builtins.py
>>     bialix> +++ bzrlib/builtins.py
>>     bialix> @@ -2065,16 +2065,28 @@
>>     bialix>                       Option('cache-dir', type=str,
>>     bialix>                              help='a directory to cache intermediate'
>>     bialix>                                   ' benchmark steps'),
>>     bialix> +                     Option('clean',
>>     bialix> +                            help='clean temporary tests directories'),
>>     bialix>                       ]
> 
>> What about: 'clean temporary tests directories without running tests'
> 
> Thanks for suggestion. Here is updated patch.
> 
> Alexander
> 

I'm not sure if 'selftest' is the right place to put something like this.

We do have 'bzr clean-tree' and 'bzr clean-tree --detritus' as part of
bzrtools. 'bzr clean-tree --detritus' removes all of the .~1~ files, as
well as the test directories.

I do understand the need for something. And maybe it is the most
discoverable as an option to selftest.

But since this only really works as something for bzr itself, it seems
like bzrtools already has a solution.

But if people like it enough, I won't stand in the way. I just wanted to
voice a point of view.

John
=:->