[PATCH] [0.13] Bug #74759

[Vincent Ladeuil]

>>>>> "david" == David Cournapeau <david at ar.media.kyoto-u.ac.jp> writes:

    david> Vincent Ladeuil wrote:
    >>>>>>> "vila" == Vincent Ladeuil <v.ladeuil+lp at free.fr> writes:
    >> 
    >>>>>>> "jam" == John A Meinel <john at arbash-meinel.com> writes:
    jam> John Arbash Meinel has voted +1 (conditional).
    jam> Status is now: Semi-approved
    jam> Comment:
    >> 
    jam> We need to support proxies, and this might even be a
    jam> sufficient enough regression that we need to create a
    jam> 0.13.1.
    >> 
    vila> Not yet, the fix solves only part of the problem.
    >> 
    >> It was still choking if the no_proxy environment variable was
    >> used.
    >> 
    vila> I'm working on it.
    >> 
    >> The attached patch is better. 
    >> 
    >> Note that urllib2 just ignores the no_proxy environment
    >> variable... so we do better here.
    >> 
    jam> It would be nice to be tested, though we didn't have
    jam> proxy tests before.
    >> 
    >> Still not done, but I thought the priority was to provide a
    >> correct implementation.
    >> 
    >> Next will be to provide a *tested* implementation and come back
    >> to TDD asap ;)
    >> 
    >> By the way, I couldn't find a definitive answer to the question:
    >> "What is the syntax and meaning of the no_proxy var". So I picked
    >> up a definition that should suit most of the needs:
    >> 
    >> - a list of domains separated by commas ',',
    >> - each domain can specify an optional port,
    >> - '?*' glob chars are allowed.
    >> 
    >> David Cournapeau (who discovered the bug) also use 127.0.0.0/8,
    >> but I found nobody else to back up that use ;)

Googled :

https://bugzilla.mozilla.org/show_bug.cgi?id=72444

Which may explain your setting, I think it's targeted to Firefox
in a strange kind of way.

Also note that the origin is an MSIE-ism.

We are getting far away from what bzr MUST handle IMHO.

I will leave my ears wide open for other such requests, but I'd
like others to speak on the subject so I put the mailing list
back in the loop.

    david> For what it worth, the no_proxy variable seems to be
    david> set by gnome through the system/preferences/network
    david> proxy dialog (if I go to a tty, the no_proxy is not
    david> set). I really cannot remember having put thoses
    david> values, though, specially the 127.0.0.0/8 (what does
    david> that mean ? Is it a subnetwork address ? I cannot see
    david> any meaning for the /8) ;

That's a network range, i.e. the same as 127.0.0.* (which should
be handled by my last patch as well as Firefox[1]).

    david> it is also set up this way on my laptop which also run
    david> on ubuntu edgy, but on a different network (with a dns
    david> server).

If someone knows how to find who set this default, I'm all ears
too.

        Vincent

[1]: http://www.mozilla.org/quality/networking/docs/aboutno_proxy_for.html