[rfc] many SFTP tests failed on win32 with Permission denied error

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

======================================================================
ERROR: test_make_tree_for_sftp_branch
(bzrlib.tests.test_selftest.TestSFTPMakeBranchAndTree)

vvvv[log from
bzrlib.tests.test_selftest.TestSFTPMakeBranchAndTree.test_make_tree_for_sftp_branch]
created control directory in
file:///D:/Bazaar/sandbox/selftest.fixes/test0000.tmp/
creating repository in
file:///D:/Bazaar/sandbox/selftest.fixes/test0000.tmp/.bzr/.
creating branch <bzrlib.branch.BzrBranchFormat5 object at 0x00C1DA30> in
file:///D:/Bazaar/sandbox/selftest.fixes/test0000.tmp/.bzr/
got branch format Bazaar-NG Metadir branch format 5
got branch format Bazaar-NG Metadir branch format 5
opening working tree 'D:/Bazaar/sandbox/selftest.fixes/test0000.tmp'
failed to open
D:/Bazaar/sandbox/selftest.fixes/test0000.tmp/.bzr/checkout/stat-cache:
[Errno 2] No such file or directory:
u'D:/Bazaar/sandbox/selftest.fixes/test0000.tmp/.bzr/checkout/stat-cache'
write hc
created control directory in
sftp://foo@localhost:3025/D%3A/Bazaar/sandbox/selftest.fixes/test0000.tmp/test_selftest.TestSFTPMakeBranchAndTree.test_make_tree_for_sftp_branch/work/t1/

^^^^[log from
bzrlib.tests.test_selftest.TestSFTPMakeBranchAndTree.test_make_tree_for_sftp_branch]
- ----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\tests\test_selftest.py",
line 979, in test_make_tree_for_sftp_branch
    tree = self.make_branch_and_tree('t1')
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\tests\__init__.py", line
1587, in make_branch_and_tree
    b = self.make_branch(relpath, format=format)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\tests\__init__.py", line
1383, in make_branch
    repo = self.make_repository(relpath, format=format)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\tests\__init__.py", line
1405, in make_repository
    made_control = self.make_bzrdir(relpath, format=format)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\tests\__init__.py", line
1399, in make_bzrdir
    return format.initialize_on_transport(t)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\bzrdir.py", line 1136,
in initialize_on_transport
    control_files.unlock()
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\lockable_files.py", line
258, in unlock
    self._lock.unlock()
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\lockdir.py", line 239,
in unlock
    self.transport.rename(self._held_dir, tmpname)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\transport\sftp.py", line
737, in rename
    ': unable to rename to %r' % (rel_to))
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\transport\sftp.py", line
699, in _translate_io_exception
    self._translate_error(e, path, raise_generic=False)
  File "D:\Bazaar\sandbox\selftest.fixes\bzrlib\transport\__init__.py",
line 241, in _translate_error
    raise errors.PermissionDenied(path, extra=e)
PermissionDenied: Permission denied: 'branch-lock/held': [Errno 13]
Permission denied

======================================================================

What this error means?
Any suggestions how to fix it?

Alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFbwpqzYr338mxwCURAh3fAJ9e5YO30wAN8P/xoUgQJ6wxI5J29gCfaYGZ
NTewV6lGO/1kXPanjWMHdaA=
=MZiw
-----END PGP SIGNATURE-----