[bug 0.11] bzr ci -m allow no message to be specified
Matthew Hannigan
mlh at zip.com.au
Sat Nov 25 09:48:49 GMT 2006
On Fri, Nov 24, 2006 at 07:09:02AM +0200, Jari Aalto wrote:
> Martin Pool <mbp at canonical.com> writes:
>
> > On 23/11/2006, at 11:55pm, Matthew Hannigan wrote:
> > [ ... ]
> > > That's an important point, but think it's still worth doing.
> > > You could error out if not a terminal.
> > >
> > > The case where the intended commit message is the name of a single
> > > file and you want to commit every change must be _vanishingly_
> > > rare.
> > >
> > > The case where you intend to commit just one file but in
> > > fact accidentally commit everything is not particularly rare,
> > > and the consequences might be severe. Especially in a script,
> > > where the error might not be realised till quite a few commits
> > > later.
> >
> > I filed this as https://launchpad.net/products/bzr/+bug/73073
> >
> > On the other hand, unlike svn, we have an easy and effective uncommit
> > command, so perhaps this should just give a warning and proceed.
>
> Not a good idea. In scripts this will go unnoticed. An error is
> better.
You could even argue that that case deserves to
fail just on log message quality grounds.
MAtt
More information about the bazaar
mailing list