[bug 0.11] bzr ci -m allow no message to be specified

[Jari Aalto]

James Westby <jw+debian at jameswestby.net> writes:

> On (24/11/06 07:09), Jari Aalto wrote:
> > Martin Pool <mbp at canonical.com> writes:
> > > On the other hand, unlike svn, we have an easy and effective uncommit
> > > command, so perhaps this should just give a warning and proceed.
> > 
> > Not a good idea. In scripts this will go unnoticed. An error is
> > better.
> > 
> 
> You seem very keen on scripting bzr, and while that could be supported I
> don't see why this case matters to you too much, a script isn't really
> going to accidentally forget to pass the argument is it?
> 
> And anyway, 
> 
>   [ -z $msg ] || bzr ci -m $msg $file
> 
> works doesn't it?

Sure, but programs should work in a predictable matter. A Script
should not need to make any "special tests"". I would see that as
a sign of bad design. The call

    grep || echo "Failed

is standard behavior. If some commands fail and some commands do not, this
makes a nightmare. It's better to just quit and return error code.

Jari