[BUG] TooManyConcurrentRequests during commit

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm not sure how this exactly happened, but I was using a bound branch
over the smart transport. I went to commit a merge of bzr.dev, which
involves modifications to lots of files.

bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium
'<bzrlib.transport.smart.SmartSSHClientMedium object at 0x70f3f0>' has
reached its concurrent request limit. Be sure to finish_writing and
finish_reading on the current request that is open.

This is the traceback that I got:

Traceback (most recent call last):
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 626,
in run_bzr_catch_errors
    return run_bzr(argv)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 588,
in run_bzr
    ret = run(*run_argv)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 292,
in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/builtins.py", line 1875,
in run
    reporter=reporter)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/decorators.py", line 51,
in write_locked
    return unbound(self, *args, **kwargs)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/mutabletree.py", line
126, in commit
    revprops=revprops, *args, **kwargs)
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/commit.py", line 352, in
commit
    self._cleanup()
  File "/Users/jameinel/dev/bzr/bzr.dev/bzrlib/commit.py", line 472, in
_cleanup
    raise e
TooManyConcurrentRequests: The medium
'<bzrlib.transport.smart.SmartSSHClientMedium object at 0x70f3f0>' has
reached its concurrent request limit. Be sure to finish_writing and
finish_reading on the current request that is open.



As near as I can tell, SmartSSHClientMedium only supports a single
request at a time. So it seems like a genuine bug that we aren't calling
finish_writing or finish_reading somewhere.

This is from the current bzr.dev tip:
Bazaar (bzr) 0.13.0dev0
  from bzr checkout /Users/jameinel/dev/bzr/bzr.dev
    revision: 2135
    revid: pqm at pqm.ubuntu.com-20061111170313-7046f63cb736a63f
    branch nick: bzr.dev

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFWngkJdeBCYSNAAMRAhVxAJsG8iIp5ZBSxVDfaY4VGgn9pU4UVQCeOTf9
ro94PlQAkNjr73ysLqteIfg=
=bN6g
-----END PGP SIGNATURE-----