[RFC] Clean up progress bars during fetch

[Wouter van Heyst]

On Sat, Nov 04, 2006 at 11:57:06AM -0600, John Arbash Meinel wrote:

...

> TODO:
>   The biggest thing that needs to be done at this point is to change the
>   HTTP.readv() implementation. Right now it doesn a big download, then
>   breaks up the file and yields the data. What we really need is for it
>   to yield the data as it is read. sftp and local transports do this,
>   and it means that we can get a meaningful progress while we are
>   downloading inventory.knit to find what file ids are involved. If you
>   want to see the difference use a machine that you have access over
>   sftp and http, and you can see how the phase 1/6 over sftp has a nice
>   updating progress, and over http it just hangs while it downloads all
>   the data.

While I'd agree with yielding it earlier on, I can't see a difference
between sftp and http progress output at the moment?

> It would be really nice to have people play with this, and let me know
> if they think it is better than what we used to do. If people like it,
> then I'll spend the time to fix up any broken tests, and get it merged.
> (*I* like it, so I will probably do it anyway, but feedback always helps)

I think it's an improvement, though it could still be more finegrained.

> # Bazaar revision bundle v0.8
> #
> # message:
> #   Fix bug in Knit.iter_lines_added_or_present_in_versions which was re-using a variable
> # committer: John Arbash Meinel <john at arbash-meinel.com>
> # date: Sat 2006-11-04 11:43:27.471999884 -0600

I like the result, but not really knowing how progress bars work, I must
confess not being sure what the changes were. Everything seems to move
up a level?

Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061108/518680fd/attachment.pgp