[BUG] selftest failure if error has % character

John Arbash Meinel john at arbash-meinel.com
Thu Nov 2 22:44:17 GMT 2006

With Martin's latest changes to make the selftest progress much nicer, I
found a small bug.

Basically, if a test fails, and that string has a '%' character in it,
then you get a python failure to expand string. Specifically, it calls

self.pb.note('FAIL: %s\n%s' % (foo, bar))
And note is calling:

self.write(format % args)

The attached patch fixes the bug, but I don't have time to write test
cases right now. I'm trying to fix some other bugs. (It just happened
that the tests I *was* writing was triggering these bugs).

The biggest problem with this bug is it happens outside of the
TestRunner safety net, so it stops the test suite entirely, and you
don't get a nice enough error to figure out what error is failing.

I should get to tests tomorrow, but I figured I would report the problem

-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_fail_with_percent.patch
Type: text/x-patch
Size: 2176 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061102/825b2c8c/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061102/825b2c8c/attachment.pgp 

More information about the bazaar mailing list