Commit does not allow missing email address but whoami says this is allowed

[John Arbash Meinel]

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Nicholas Allen wrote:
>>>
>>>> As we are working on an internal closed source system we probably would
>>>> not want to set our email address.
> 
> But even on an internal, closed-source system, you'll want to set it to
> something meaningful, because that identifier is used in commit logs.
> 
>>> All we really care about is having "something at other", it doesn't have to
>>> be a valid email address. But even that we shouldn't strictly require. I
>>> tracked down one place that was expecting it, it seems you might be
>>> running into another.
> 
> I think it's a Windows thing.  On Unix, we fall back to the userid at hostname.
> 
> Aaron

Actually, I think that even on Windows we use user at host. On windows we
have getpass.getuser() + "@" socket.gethostname()
On other platforms we use

entry = pwd.getpwuid(os.getuid())
name = entry.pw_gecos.decode('utf-8')
username = entry.pw_name.decode('utf-8')

"Name <username at socket.gethostname()>"

The problem is he is explicitly setting it to something with 'bzr whomai
"Joe Blo"' and bzr currently requires X at Y when committing.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061101/77c56f1c/attachment.pgp