[PATCH] stripping trailing slashes from ignore patterns (#4559)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Kent Gibson wrote:
> 
>>This is my latest patch which incorporates Cheuksan Edward Wang's 
>>ignore_multiple_5.patch and my #4559 changes including review comments
>>from Aaron Bentley.
>>
>>My previous bundles were borked (thanks to Aaron for pointing this out)
>>but this one should merge into bzr.dev.
>>
>>My changes have gotten a +1 from Aaron so could one of the other cores
>>give them the once over?
>>
>>Cheers,
>>Kent.
>>
> 
> 
> I saw that Aaron reviewed your changes, but I didn't see an actual +1
> 
> The changes look good to me, though. The only thing that doesn't seem to
> be tested is if you already have a rule with a trailing '/' in
> .bzrignore, it should still match files that patch the prefix.
> 
> eg:
>   $ bzr init
>   $ echo "foo/" >> .bzrignore
>   $ touch foo
>   $ bzr ignored
>   foo    foo/
> 
> I realize that people might be a little confused by that one, because we
> are ignoring the trailing slash.
> 
> Maybe it would be better to issue a warning if .bzrignore has a trailing
> slash in it, and then ignore it, rather than have people thinking it
> will only ignore a directory, or something like that.
> 
> So, short-term, I still think the patch is worthy to be merged.
> Long-term it would be nice if we refined things a little bit more.

That was my feeling, too.

+1, to be explicit.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFR4hU0F+nu1YWqI0RAv/gAJ4hybpDOI0LEMV9TqBIIZl6Rxvy5gCeI5DG
qepoDswtS6W15aTbXfxCgiM=
=wdJt
-----END PGP SIGNATURE-----