[PING] [PATCH] show full name of plugin in help

[Alexander Belchenko]

Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> I'd like to know status of my patch. Is it rejected or forgotten? Or
>> delayed for 0.13? Or?..
>>
>> I understand that my changes is minor and intended only for versioned
>> plugins (e.g. bzrtools-0.11/0.12, bzr-gtk-0.11/0.12). But anyway it
>> could be useful.
> 
> IMHO, plugins should not have periods in their directory names.
> 
> Bzrtools assumes its package name is "bzrlib.plugins.bzrtools".
> 
> Similarly, bzr-gtk assumes its package name is "bzrlib.plugins.gtk"

For me it means that my patch is rejected. It's OK for me.

But I think that your position is *wrong* here.

Recently in flame with git zealots you say that bzr have very good 
plugin architecture. And this indeed is.

Anyone can simply download tarball with plugin release, unpack it and 
simply place it to ~/.bazaar/plugins. And it's *just* *works*.You don't 
need to care about period, comma and all that jazz. And IMO it's *right* 
*thing*.

Now you say me that it's wrong. I don't care because it's works. I just 
want to bzr be more consistent. But I see -- this impossible. I give up.

Now I want give more details about bzrtools and bzr-gtk.

All commands that I use from bzrtools works well either bzrtools in 
bzrtools-0.11 (0.12) directory or simply bzrtools, or even 
bzrtools.bialix (when I want to hacking it a bit). If bzrtools have 
hardwired assumptions about their location in bzrlib.plugins.bzrtools -- 
then it stupid for me.

Because bzr-gtk is such stupid thing. It *require* to be installed to 
bzrlib.plugins.gtk. That's in turn require to have bzr itself to be 
installed (and when we use standalone bzr.exe that store all their 
compiled pyc files of bzrlib inside library.zip -- you could see that 
installing bzr-gtk in this situation almost impossible). And this 2 
facts means for me that bzr-gtk break important plugin feature: be 
independent from main application as much as possible. Plugin means for 
me that I can simply plug it in and plug it out when needed.

BTW, bzr-gtk in facts not so bad as I say, because most commands works 
when it not installed, only gdiff require to bzr-gtk satisfy stupid 
requirement to be physically installed into bzrlib.plugins.gtk. Because 
it have hardwired import path:

from bzrlib.plugins.gtk.viz.diffwin import DiffWindow

I simply change this to

from viz.diffwin import DiffWindow

and it works without installing. Heya!

I think that installing plugins it's *bad* idea and break main plugins 
idea. And require to plugin have canonical python name is also bad idea 
because now it works in any case.

--
Alexander