[patch]bug 32054 if commit fails commit message draft is lost

[Martin Pool]

On 19 Oct 2006, Martin Pool <mbp at canonical.com> wrote:
> On 18 Oct 2006, Cheuksan Edward Wang <wang02139 at gmail.com> wrote:
> >      2) If the Unicode commit message isn't valid in
> >      'bzrlib.user_encoding()', that is okay, we don't try to save it if we
> >      can't. I don't really want to see us use "replace" because then we have
> >      generated a corrupted message. Though it is a judgment call whether it
> >      is better to save most of the message even if some of the characters are
> >      incorrect.

If you think about where the message comes from, it's either from a
message file or from the command line.  In either case it is decoded
coming in using user_encoding, so it's very unlikely that it can't be
reencoded that way when it's put back out.  So modulo John's other
comments, +1 from me.

-- 
Martin