typo in errors.TransportNotPossible

[John Arbash Meinel]

Robert Collins wrote:
> On Wed, 2006-09-27 at 14:25 -0500, John Arbash Meinel wrote:
>> Lukáš Lalinský wrote:
>>> There is a typo in the error message for errors.TransportNotPossible. Currently
>>> it always returns an extra '%', e.g.:
>>>
>>> "bzr: ERROR: Transport operation not possible: readonly transport %"
>>>
>>> -Lukáš
>>>
>> Agreed. The attached patch includes your fix, as well as adding a test case.
>>
>> We really need to do an audit of the errors.py file.
>>
>> Robert has approved changing it so that we use a real member rather than
>> the doc string. So when we get to that change, we should do an audit of
>> the strings.
>>
>> Seeking a +1 for this patch, though.
> 
> your patch looks fine, though I'm confused by the new class. Are the
> other tests not specific enough ?
> 
> Rob

The point of the new class is to give a place to test error formatting.
Right now we have very few tests that check the output string of an
exception.

We have tons of tests that check that the correct error is raised, but
very few that check that the end user sees what we want them to see.

Perhaps you are thinking that this should be a test_transport-* test.

I was just trying to get us started on actually testing that exceptions
are readable and understandable by the end user.

The other classes in that file didn't really fit that concept.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060929/269b8f6b/attachment.pgp