typo in errors.TransportNotPossible

Robert Collins robertc at robertcollins.net
Fri Sep 29 00:47:33 BST 2006


On Wed, 2006-09-27 at 14:25 -0500, John Arbash Meinel wrote:
> Lukáš Lalinský wrote:
> > There is a typo in the error message for errors.TransportNotPossible. Currently
> > it always returns an extra '%', e.g.:
> > 
> > "bzr: ERROR: Transport operation not possible: readonly transport %"
> > 
> > -Lukáš
> > 
> 
> Agreed. The attached patch includes your fix, as well as adding a test case.
> 
> We really need to do an audit of the errors.py file.
> 
> Robert has approved changing it so that we use a real member rather than
> the doc string. So when we get to that change, we should do an audit of
> the strings.
> 
> Seeking a +1 for this patch, though.

your patch looks fine, though I'm confused by the new class. Are the
other tests not specific enough ?

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060929/518c855f/attachment.pgp 


More information about the bazaar mailing list