how to verify gpg-signed commits

[James Henstridge]

On 15/09/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
> > There is only one crasher bug I've run into with the current version
> > (to do with listing/reading keys), and that turned out to be a
> > double-free bug in gpgme itself.  That bug was fixed in 1.1.0 though.
> >
> > If you can provide details of the crash, I can take a look at it.
>
> Well, probably that was the bug, because at least now everything runs
> without a segfault on FC4 with gpgme-1.1.2-19.fc4.at
>
> However, quite a few of the tests fail. Specifically:
> ======================================================================
> FAIL: test_keylist_mode (gpgme.tests.test_context.ContextTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/jameinel/dev/bzr/pygpgme/gpgme/tests/test_context.py",
> line 95, in test_keylist_mode
>     self.assertRaises(gpgme.GpgmeError, set_keylist_mode, ctx, 128)
> AssertionError: GpgmeError not raised

This test was designed to check that set_keylist_mode() returned an
error when an invalid keylisting mode was provided.  I guess the
invalid mode I used is valid with the newer versions.  I suppose this
part of the test could be removed.

> ======================================================================
> FAIL: test_key1 (gpgme.tests.test_keys.KeyTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/jameinel/dev/bzr/pygpgme/gpgme/tests/test_keys.py", line
> 71, in test_key1
>     self.assertEqual(key.subkeys[1].fpr, None)
> AssertionError: '0625D8580ABB0BD430B5862E659A6AC69BC3B085' != None

This indicates that more key information is being provided in the
default keylisting mode.  I'll investigate further.

>
> ======================================================================
> FAIL: test_key2 (gpgme.tests.test_keys.KeyTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/jameinel/dev/bzr/pygpgme/gpgme/tests/test_keys.py", line
> 127, in test_key2
>     self.assertEqual(key.subkeys[1].fpr, None)
> AssertionError: 'A283D12125B64FE40437E964A95221D00DCBDD64' != None

This is the same as the above.

>
> ======================================================================
> FAIL: test_revoked (gpgme.tests.test_keys.KeyTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/jameinel/dev/bzr/pygpgme/gpgme/tests/test_keys.py", line
> 183, in test_revoked
>     self.assertEqual(key.subkeys[1].fpr, None)
> AssertionError: '3C67C7748BE5A26665E10869E50B59CF50CE4D54' != None

And again.

> Now, all of the tests pass for libgpgme11 (1.1.0-1 on Ubuntu Dapper).
>
> Judging by the error, I don't know that these tests are 100% meant to
> pass. (It looks like gpgme-1.1.0 is giving incomplete data that
> gpgme-1.1.2-19 is returning).

The above test failures look harmless, but they should be fixed.  I'll
look at fixing those problems (probably by loosening the affected
tests).


> I haven't been able to test on the Mac yet, because darwinports decided
> to be uncooperative when I wanted to update everything.

I'd expect that you see similar test failures to those above, or no
errors at all.  I would be interested if you are still seeing segfault
failures though.

James.