win32 selftest results with @1993

[John Arbash Meinel]

The last few updates seem to have helped with win32 selftest failures. I
still have a little bit of problem with running out of filesystem space.
So to give myself some more breathing room, I changed:

        short_id = self.id().replace('bzrlib.tests.', '') \
                   .replace('__main__.', '')[-100:]
to
        short_id = self.id().replace('bzrlib.tests.', '') \
                   .replace('__main__.', '')[-50:]

Anyway, with that change we are down to:
FAILED (failures=2, errors=4)


1 failure is 'test_external_diff', which on this system is creating
'\r\n' line endings. We could either skip the test, or check both forms
(with and without \r, and pass it either way).


The other failure is very surprising, and possibly an issue. It seems to
be a floating point resolution issue. Specifically:
FAIL: test_pack_revision_5 (bzrlib.tests.test_xml.TestSerializer)
bzrlib.tests.test_xml.TestSerializer.test_pack_revision_5]------
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\dev\bzr\bzr.dev\bzrlib\tests\test_xml.py", line 250, in
test_pack_revision_5
    self.assertEqualDiff(outfile_contents, _expected_rev_v5)
  File "/cygdrive/c/dev/bzr/bzr.dev/bzrlib/tests/__init__.py", line 524,
in assertEqualDiff
AssertionError: texts not equal:
- <revision committer="Martin Pool &lt;mbp at sourcefrog.net&gt;"
format="5" inventory_sha1="e79c31c1deb64c163cf660fdedd476dd579ffd41"
revision_id="mbp at sourcefrog.net-20050905080035-e0439293f8b6b9f9"
timestamp="1125907235.211783900" timezone="36000">
?                           ^^^
+ <revision committer="Martin Pool &lt;mbp at sourcefrog.net&gt;"
format="5" inventory_sha1="e79c31c1deb64c163cf660fdedd476dd579ffd41"
revision_id="mbp at sourcefrog.net-20050905080035-e0439293f8b6b9f9"
timestamp="1125907235.211783886" timezone="36000">
?                           ^^^

So you can see that the timestamp has been altered in the conversion
process.


Some of the tests with ERROR:
ERROR: test_fetch_funky_file_id
(bzrlib.tests.interrepository_implementations.test_interrepository.TestInterRepository)

  File "C:\dev\bzr\bzr.dev\bzrlib\osutils.py", line 905, in check_legal_path
    raise IllegalPath(path)
IllegalPath: The path
C:/dev/bzr/bzr.dev/test0001.tmp/epository.test_fetch_funky_file_id(InterWeaveRepo)/work/tree/.bzr/repository/weaves/b5/funky-chars<>%&;"'.weave
is not permitted on this platform

So that test probably just needs to be updated to catch IllegalPath and
skip the test, rather than fail with an ERROR. This test is failing 2
times. It is failing for InterRepository and InterWeaveRepo. Both
involve weaves, and weaves with funky characters are not supported on
Windows.


The final 2 error tests are:
ERROR: test_connection_paramiko
(bzrlib.tests.test_sftp_transport.SSHVendorConnection)

which fails with:
    raise failure_exc(path, str(e) + more_info)
PathError: Generic path error:
u'/:/dev/bzr/bzr.dev/test0001.tmp/sport.SSHVendorConnection.test_connection_paramiko/work/a_file':
Failure: error retrieving)

And:
ERROR: test_readonly_http_works
(bzrlib.tests.test_versionedfile.TestWeaveHTTP)

which fails with:
  File "C:\dev\bzr\bzr.dev\bzrlib\osutils.py", line 188, in fancy_rename
    rename_func(new, tmp_name)
OSError: [Errno 13] Permission denied

Now, this last one is AtomicFile failing during .commit() As part of
LocalTransport.put().

Now it may be that we are getting Permission Denied, when we expect
NoSuchFile, or something like that (say the parent dir doesn't exist yet).

But this seems like it might also be an issue, something to look into.

Oh... And errno=17 (which someone has mentioned in the past) seems to
happen when we run out of filesystem space.

Anyway, we've seem to overcome the bulk of our errors on win32. But I
think we need to still do a little bit more.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060909/df64e403/attachment.pgp