[MERGE] bzrlib API to add revision properties to a working tree

[James Henstridge]

On 08/09/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > +        self.assertRaises(ValueError,
> > +                          t.add_revision_property,
> > +                          'n\xC3\xA2me', 'value')
>
> ^- Why did you use a utf-8 string, rather than a Unicode string?

An oversight.  It should have been a unicode string.

> >  MERGE_MODIFIED_HEADER_1 = "BZR merge-modified list format 1"
> >  CONFLICT_HEADER_1 = "BZR conflict list format 1"
> > +REVISION_PROPERTIES_HEADER_1 = "BZR revision properties list format 1"
>
> ^- I realize you are following the crowd here, but I thought we
> preferred using the name Bazaar over BZR. (At least you aren't using
> Bazaar-NG).

Fixed this too, so it reads "Bazaar revision properties list format 1"


> So a couple small comments, but you still have my +1. (I would like BZR
> => Bazaar to be resolved, since this is a format on disk, so it lasts a
> while).

An updated bundle is attached.  The changes are also available from this branch:

    http://people.ubuntu.com/~jamesh/bzr/bzr.pending-revprops

James.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: workingtree-revprops.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060908/565fc5d7/attachment.diff