[MERGE/RFC] Dotted-decimal revision numbers in 'bzr log'

[Robert Collins]

On Thu, 2006-09-07 at 13:33 -0500, John Arbash Meinel wrote:
> Robert Collins wrote:
> > This adds the dotted decimal revision numbers merge_sorted can create
> > into the output of log.
> > 
> > There are a couple of gotchas, which I will add to NEWS before merging
> > [assuming approval ;)] - I forgot to do so when writing the NEWS entry.
> 
> So with all this discussion, I think it is still worthwhile to bring it
> in. I think it is something that should be pulled in early on a release
> cycle, rather than later, so we can have some time to decide if we like
> it or not.
> 
> My concerns-
> 
> 1) I'm concerned about the performance impact on merge_sorted. If you
> have it disabled, does it still cause performance issues, or is it only
> when get_revno = True?

Its on for all cases.

> This is a general concern about our algorithm, though, since we require
> a full ancestry for all of our merge code. We don't want
> bzr log -r 100000..100010 to take a super long time, when we are only
> displaying a few revisions.

Right now we this has not changed the complexity of log etc. But it does
make it harder to optimise in the future to do partial graph walks. Note
that log -r 10K..10K+10 already walks all the revisions. I'll run the
log benchmarks before and after and give results for that today.

> Also, how would something like this interact with a shallow checkout?

By shallow you mean partial history? Well, all it needs is the revision
graph in total, not the revision data, so assuming we have kept that
cached, it should be fine.

> 2) There are a few typos in the diff. Nothing serious, and I think
> Martin caught the ones I really care about.

Yup, fixing.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060908/5aba79e5/attachment.pgp