[MERGE] enable mode tests for SFTP

John Arbash Meinel john at arbash-meinel.com
Wed Sep 6 22:49:07 BST 2006


In trying to debug some other code, I found a bug which should have been
caught by the permissions tests. In looking closer, I found that they
were not enabled for sftp.

Further, once I enabled them, I found out that 'os.open()' defaults to
creating files with mode 0777, rather than 0666. Which means that all
this time, all of the sftp tests have been creating executable files in
the test directories.

The attached patch re-enables mode tests for sftp, and fixes
StubSFTPServer to use 0666 as the default file mode.

It also refactors SFTPTransport.mkdir() slightly, because I need to use
the helper in another location for another patch I am submitting.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sftp_mode.patch
Type: text/x-patch
Size: 2751 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060906/1713680b/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060906/1713680b/attachment.pgp 


More information about the bazaar mailing list