[RFC] benchmark display changes

John Arbash Meinel john at arbash-meinel.com
Mon Aug 21 03:02:15 BST 2006


Robert Collins wrote:
> On Fri, 2006-08-18 at 11:17 -0500, John Arbash Meinel wrote:
> 
> 
>> So right now, I would prefer seeing: measured/other
>> We could also do: measured/other/total
>>
>> But that starts to take up a lot of space.
> 
> having total is nice for consistency. So I'd prefer measured/other/total
> to measured/other.
> 
> -Rob

I understand your point, I'm a little concerned about running out of
display room, for both the test name and all of the timing values.

I also think there is a small bug since 0.9 about the time displayed for
non-benchmark tests.
Running: 'bzr selftest -v nonascii' now gives:

...cii.NonAsciiTest.test_add_in_nonascii_branch   OK         150ms

bzr-0.9 gives the same output, while bzr-0.8 gives:
test_nonascii.NonAsciiTest.test_add_in_nonascii_branch    OK   672ms

So there are 2 changes.
1) It doesn't use as much of the terminal width. It now uses 2 fewer
characters than it used to.

2) It allocates more space for the time than it really needs.

Now, this might have existed from whenever benchmarks were first
introduced, and I'm just seeing it now. But especially if I was
considering adding a third column, I wouldn't want the standard tests to
have even less room to display the test names.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060820/a6586065/attachment.pgp 


More information about the bazaar mailing list