[MERGE] trivial NotImplementedError and docstring tweaks

John Arbash Meinel john at arbash-meinel.com
Thu Aug 17 14:48:21 BST 2006


Andrew Bennetts wrote:
> On Thu, Aug 17, 2006 at 01:37:05PM +1000, Andrew Bennetts wrote:
>> This patch mainly updates a bunch of NotImplementedErrors in bzrlib/branch.py
>> from this style:
> 
> Obviously, it helps if I don't attach an empty file...
> 
> -Andrew.

...

> -class SFTPTransport (Transport):
> -    """Transport implementation for SFTP access"""
> +class SFTPTransport(Transport):
> +    """Transport implementation for SFTP access."""


I thought PEP8 said you were only supposed to use a '.' when in
paragraph mode.

Interestingly, PEP-257 says to use a period. But the explicit example in
PEP-8 (which references 257) doesn't.

Interestingly, 257 says that this is okay:
"""
First line starts here.

More stuff

"""

They also ask for an extra blank line at the end. I don't think we have
used that at all, and as such, I don't prefer the look of it.

Anyway, no reason to block the patch (especially since it is already
merged). Just a discussion on doc strings.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060817/28034efc/attachment.pgp 


More information about the bazaar mailing list