[PING] [MERGE] fix xml serializer for timezone=0
John Arbash Meinel
john at arbash-meinel.com
Tue Aug 15 18:04:57 BST 2006
John Arbash Meinel wrote:
...
> I wasn't sure if it was okay to change timestamp=None => timestamp=0
> Because early early bzr revisions actually have timestamp="Not Set"
> (they were committed in your AU timezone, but you weren't setting the
> timezone at that point).
>
> But I think we can afford a couple bogus TZ=UTC for old versions, rather
> than having to continue the legacy of timezone=None.
>
> Right now, if the writer is writing a '0', then the reader will do the
> right thing. Changing the reader is just a compatibility hack for any
> data that was written incorrectly.
>
> Anyway, attached is a fix for the timezone stuff. I also upgraded the
> generic revision tests to be in repository_implementations, since they
> tend to depend on the serialization method, and if that ever changes, we
> want to know it.
>
> John
> =:->
I updated the patch a little bit, mostly just marking that it also fixes
bug #56290:
https://launchpad.net/products/bzr/+bug/56290
They seem to want this bug fix as part of packaging for NetBSD and
Debian, so it might be nice to get it merged soon.
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060815/71601c9b/attachment.pgp
More information about the bazaar
mailing list