aftp:// transport is degenerated to ftp://

[ghozzy _]

Hello,

When i tried to use aftp:// transport with push command, it didn't work telling
bzr: ERROR: socket.error: (61, 'Connection refused')
because my firewall blocked it. Then i tried ftp:// and realized their
behavior don't differ at all and they both work as passive ftp.

I strarted my investigation and found out that aftp:// prefix with
FtpTransport is degenerated to ftp:// and is effectively using passive
connection anyway.
I looked around the code and made a little change to
FtpTransport._unparse_url() method so it actually produces "aftp://"
prefix if connection is active instead of always "ftp://". With this
change it started to work for me. Diff is attached.

Would please anyone check if this fix is appropriate and if it is, commit it ?

With best regards,
--
ghozzy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ftp.py-patch
Type: application/octet-stream
Size: 598 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060815/8f54c788/attachment.obj