[MERGE] updated benchmark caching

[Martin Pool]

On 14 Aug 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Martin Pool wrote:
> > +1 with comments, as long as (as it seems?) caching is off by default.
> 
> It wasn't, but in this latest update it is.

Great, my +1 before stands.

> > Just a comment: you could also write this as a base class where
> > particular methods are overridden to specialize handling of particular
> > files.  I'm not sure doing so would be really much better, but it's
> > arguably consistent with the generally OO (rather than functional) style
> > we use.
> > 
> > For example in test_copy_tree_handlers it could accumulate into the
> > copier object.
> > 
> 
> Well, there is a tradeoff between functionality by inheritance and
> functionality by association. I'm using a function that takes a
> customized data structure. You could arguably do it as 2 classes that
> work with each other (one iterates over the tree, the other does the work).
> 
> If you feel strongly, I can update it.

No, I don't.

-- 
Martin