[PATH] Fix list_dir quoting in SFTPTransport and FTPTransport
David Allouche
david at allouche.net
Sat Aug 12 00:15:42 BST 2006
While attempting to convert a branch producted by baz-import to knits, I
ran into a bug of SFTPTransport.list_dir, it did not urlquote its return
value.
That actually caused Transport.copy_tree to throw an error, and there
was a ill-conceived "fix" in iter_files_recursive to work around the
list_dir bug, so I extended test_list_dir and test_iter_files_recursive
to check for proper quoting. I also added a test_copy_tree because
that's ultimately the functionality I needed.
Robert Collins told me that a fix for the same problem was recently
reviewed, but I though my patch might also be of interest, in particular
with respect to its test changes.
Please CC me in replies to this message.
--
-- ddaa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: list_dir-quoting.patch
Type: text/x-patch
Size: 8328 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060812/7185762a/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060812/7185762a/attachment.pgp
More information about the bazaar
mailing list