[MERGE] Make some tests use test suite transport rather than local

Andrew Bennetts andrew at canonical.com
Thu Aug 10 09:56:12 BST 2006


On Thu, Aug 10, 2006 at 04:05:22PM +1000, Robert Collins wrote:
> On Wed, 2006-08-09 at 15:04 +1000, Andrew Bennetts wrote:
[...]
> > +        t = self.get_transport()
> > +        try:
> > +            made_control = self.bzrdir_format.initialize(t.base)
> > +            made_repo = made_control.create_repository()
> > +            made_branch = made_control.create_branch()
> > +            made_tree = made_control.create_workingtree()
> > +        except errors.NotLocalUrl:
> > +            raise TestSkipped("Can't initialize %r on transport %r"
> > +                              % (self.bzrdir_format, t)) 
> 
> +1 with a comment : the try: block seems rather large. Wouldn't it be
> fine with just the made_tree line inside the try ?
> 
> (remember - NotLocalUrl is only raised from the tree related calls, no
> branch/repo or control.)

That's what I tried initially, but the made_control line also raised that
exception.

-Andrew.





More information about the bazaar mailing list