[MERGE] Make some tests use test suite transport rather than local
Robert Collins
robertc at robertcollins.net
Thu Aug 10 07:05:22 BST 2006
On Wed, 2006-08-09 at 15:04 +1000, Andrew Bennetts wrote:
> - t = get_transport('.')
> - made_control = self.bzrdir_format.initialize(t.base)
> - made_repo = made_control.create_repository()
> - made_branch = made_control.create_branch()
> - made_tree = made_control.create_workingtree()
> + t = self.get_transport()
> + try:
> + made_control = self.bzrdir_format.initialize(t.base)
> + made_repo = made_control.create_repository()
> + made_branch = made_control.create_branch()
> + made_tree = made_control.create_workingtree()
> + except errors.NotLocalUrl:
> + raise TestSkipped("Can't initialize %r on transport %r"
> + % (self.bzrdir_format, t))
+1 with a comment : the try: block seems rather large. Wouldn't it be
fine with just the made_tree line inside the try ?
(remember - NotLocalUrl is only raised from the tree related calls, no
branch/repo or control.)
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060810/00138a3f/attachment.pgp
More information about the bazaar
mailing list