[MERGE] transport.list_dir should always return url-escaped names.

John Arbash Meinel john at arbash-meinel.com
Tue Aug 8 14:24:45 BST 2006


Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Andrew Bennetts wrote:
>>>> I've added a test to ensure that it always returns url-escaped
>>>> names, and fixed the two broken transports.
> 
>>> +1 from me.
> 
> What's the advantage of url-escaped names?
> 
> Aaron

Transport is defined as URLs. It is just consistency (the thing you get
back is the thing you request).

We need to have the base path defined as a URL, because of some
complexities which are described in HACKING. I can go into it, but you
can also just look there.

We pay a bit for the abstraction because we are converting back and
forth a lot. The idea, though, was to make it consistent across
Transports that have no other representation.

HTTP stuff *must* go through a URL. The only other possibility would be
that the transport root is defined as a URL, and then all other paths
are defined as Unicode. But right now all of Transport is defined as
URLs, so it needs to return them. Especially since it already *requires*
them as parameters to get()/append() etc.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060808/1b2d779c/attachment.pgp 


More information about the bazaar mailing list