[BUG?] revisiontree's root node has no revision attribute set

[Robert Collins]

On Thu, 2006-07-27 at 08:31 -0500, John Arbash Meinel wrote:
> Aaron Bentley wrote:
> 
> ...
> 
> >>> We dont currently set that for the root node.
> >>>
> >>> I think a reasonable change for this is to start by setting it to the
> >>> revision_id of the revision tree.
> > 
> > Isn't the revision_id for directories only changed when we move or
> > rename them?  And therefore, isn't it impossible for it to have changed
> > since the first commit?  So shouldn't we use the revision-id of the
> > first commit?
> > 
> > The lack of a revision_id was the reason we were talking about upgrading
> > repositories for nested-trees.
> > 
> 
> What about our idea of splitting up the inventory into a per-directory
> entry. And then the root node has a place to go. Directories would be
> updated every time there was a content change (so they get the
> revision_id of the last change to anything beneath them).
> I worry a little bit about performance.
> We trade off having a single huge inventory.knit in exchange for having
> to read several inventories to do a pull.
>
> *However* we gain back the ability to not download all of those files,
> because we can tell what directories have changed.
> 
> If we have to change the inventory format which means we have to change
> the Repository format (so old client know they can't use it), it might
> be worthwhile to investigate the benefits/weaknesses of splitting up
> into per-directory inventories.

I agree with Aaron that we should not conflate our work here.

As for splitting the inventory, there are actually two separate
dimensions: theres tracking the change-revision of entire subtrees - see
my other long post for some possible details, and separately there is
splitting the physical storage. We can alter in both directions
separately.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060728/380e1fe0/attachment.pgp