[MERGE] deprecated EmptyTree

Robert Collins robertc at robertcollins.net
Fri Jul 21 05:54:59 BST 2006


On Fri, 2006-07-21 at 00:48 -0400, Aaron Bentley wrote:
> Robert Collins wrote:
> > On Thu, 2006-07-20 at 10:46 -0400, Aaron Bentley wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Aaron Bentley wrote:
> >>> Robert Collins wrote:
> >>>
> >>>>> This patch deprecated EmptyTree, replacing all uses of it with a
> >>>>> RevisionTree.
> >>>
> >>> I like the concept.  I don't like using Inventory this way, because it
> >>> produces an Inventory with a tree root, and the NULL_REVISION doesn't
> >>> have a tree root.
> >> I take it back.  This is consistent with how we're behaving now.
> > 
> > So you are +1 on this ?
> 
> Yes, I'm +1 on the whole thing.
> 
> I have some email troubles at the moment, so I may be laggy in the next
> couple days.  However, if you need  to reach me,
> abentley at panoramicfeedback.com should be fine.
> 
> To respond to your other email (Can you expand on this? When does a tree
> get a root?):
> 
> In nested-trees, the empty tree has no root file-id.  The root id is
> introduced by the first commit.  It must be introduced in the first
> commit, because the inventory serializer throws an exception if there's
> no root id.

Can it still serialize existing trees? Or does their ROOT_ID id count as
a root file-id ?

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060721/1f47e6a2/attachment.pgp 


More information about the bazaar mailing list