[merge] Bundles handle non-integer timezones

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>>> John Arbash Meinel wrote:
>>>>> Attached is a patch to handle 2 bugs in the current bundle code.
>>>>>
>>>>> 1) More graceful handling of 'bzr pull sftp://host/path' (no trailing
>>>>> slash). I submitted this a while ago, but haven't gotten any feedback.
>>> The implementation stuff looks okay, but the mutter lines look longer
>>> than 79 chars.  I'm torn about whether the serializer should convert the
>>> SFTP error into a NotABundle.  I guess it's fine where it is.
> 
> What would you prefer. We need something or you get:

I think you made the right choice.  This function explicitly handles
transports, so let's leave it as is.

> I realize it is redundant, but I think it is reasonable to make it clear
> that I am counting on the integer division truncation effect.

Okay.


> However, that isn't necessarily obvious to a user what is going on. '//'
> is pretty rare. And to a casual glance makes people think it is a comment.

Agreed, it is not well-known.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsucU0F+nu1YWqI0RArYdAJ94sHtb02UMlZhFXpDDxNY3jOd2XACfUlPs
CcRGG7Wsx3FmPtexXmNSDVo=
=6vYv
-----END PGP SIGNATURE-----