[MERGE] push handles file-ids containing quotes correctly
Aaron Bentley
aaron.bentley at utoronto.ca
Mon Jul 10 17:02:52 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
xml.sax.saxutils.unescape is horribly, horribly broken. Sure, it does
exactly what it claims, but no one should ever want what it claims to
do: convert &, <, and > but not ' or " into their
corresponding characters.
The result of using a copy of xml.saxutils.unescape in
Repository.fileids_altered_by_revision_ids is that we fail to decode
file-ids containing single- or double-quotes correctly.
This bundle fixes our local _unescape_xml function to unescape all 5 of
the predefined entities described in XML 1.0 section 4.6, and also to
raise an exception if it encounters an XML entity that it cannot decode
(rather than simply ignoring it).
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFEsnos0F+nu1YWqI0RAg+DAJ9kepSDTV+JkMMh/6q4WWGuHvJdqQCaAs6+
J7pgRbIgjUE5ztD0lwTwzcM=
=rzUI
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote-file-ids.patch
Type: text/x-patch
Size: 5814 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060710/01bfdf22/attachment.bin
More information about the bazaar
mailing list