[MERGE] Fix shared BzrDir.create_repository() [ping]

[Jelmer Vernooij]

On Wed, 2006-07-05 at 16:52 -0500, John Arbash Meinel wrote:
> Jelmer Vernooij wrote:
> > On Wed, 2006-07-05 at 16:09 -0500, John Arbash Meinel wrote:
> >> v- but I don't think you need these tests. Having the test in
> >> 'bzrdir_implementations' should mean it is run for every BzrDir format.
> > These test BzrDir.create_repository(), which is static. The tests in
> > bzrdir_implementations test the various overrides of create_repository()
> > (which all take a BzrDir instance). The latter don't call
> > BzrDir.create_repository().
> > 
> > Without the tests in bzrlib/tests/test_bzrdir.py, the testsuite wouldn't
> > find the bug I fixed.
> Okay. I forgot about the static helper function. (Being named the same
> doesn't help).
> 
> +1 all around, I guess.
Ping, any news on this merge request?

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060710/978bb026/attachment.pgp