[MERGE] Fix shared BzrDir.create_repository()

John Arbash Meinel john at arbash-meinel.com
Wed Jul 5 22:52:32 BST 2006


Jelmer Vernooij wrote:
> On Wed, 2006-07-05 at 16:09 -0500, John Arbash Meinel wrote:
>> v- but I don't think you need these tests. Having the test in
>> 'bzrdir_implementations' should mean it is run for every BzrDir format.
> These test BzrDir.create_repository(), which is static. The tests in
> bzrdir_implementations test the various overrides of create_repository()
> (which all take a BzrDir instance). The latter don't call
> BzrDir.create_repository().
> 
> Without the tests in bzrlib/tests/test_bzrdir.py, the testsuite wouldn't
> find the bug I fixed.
> 
> Cheers,
> 
> Jelmer
> 

Okay. I forgot about the static helper function. (Being named the same
doesn't help).

+1 all around, I guess.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060705/784f7d39/attachment.pgp 


More information about the bazaar mailing list