[MERGE] test framework distinguishes skips

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On  7 Jul 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> Here is the revised version.  Changes are:
>> 1. Unicode error handling is as it was before, except that
>> NonUnicodeFilesystem is raised instead of a generic TestSkipped.
> 
> Great.
> 
>> 2. dependency_failure(LSProfNotPresent) has morphed into
>> depends_on('lsprof')
> 
> I don't understand why you changed from using the class name to using a
> string.  (I just looked through the thread and I don't see any
> discussion of it but maybe I missed it?)  I'd prefer the class name,
> because it will give an error if misspelled and is easier to grep for.

I originally used @dependency_failure, because the parameter was an
exception.  You wanted something along the lines of @test_requires or
@test_dependency, but it didn't seem natural to use an exception name as
a parameter, so I used the string.  (I mentioned this in my reply to
your July 6 email.)

> My preference would be @skip_on_dependency_error((LSProfNotPresent),
> which I think is what John wanted too.

I'm happy with that.

> If we can resolve #2 above then I'm +1 to merge this in.

Great.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEseGH0F+nu1YWqI0RApAgAJ99DCXQqj0e7Nwm6bCCpuubj+6kNQCgiFm0
LeOZN++cN192evjiC3s3MnQ=
=Ahyg
-----END PGP SIGNATURE-----