[MERGE] test framework distinguishes skips

[Martin Pool]

On  7 Jul 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> Here is the revised version.  Changes are:
> 1. Unicode error handling is as it was before, except that
> NonUnicodeFilesystem is raised instead of a generic TestSkipped.

Great.

> 2. dependency_failure(LSProfNotPresent) has morphed into
> depends_on('lsprof')

I don't understand why you changed from using the class name to using a
string.  (I just looked through the thread and I don't see any
discussion of it but maybe I missed it?)  I'd prefer the class name,
because it will give an error if misspelled and is easier to grep for.

My preference would be @skip_on_dependency_error((LSProfNotPresent),
which I think is what John wanted too.

> 3. platform requirments are handled with normal function calls rather
> than decorators.

Great.

If we can resolve #2 above then I'm +1 to merge this in.

-- 
Martin