[patch] hashcache fixes
Andrew Bennetts
andrew at canonical.com
Sun Jul 9 10:35:05 BST 2006
On Sun, Jul 09, 2006 at 05:46:05PM +1000, Martin Pool wrote:
[...]
> We can fix both these at once by adding a window of a few seconds, which
> is what this patch does. It also separates out and cleans up some
> tests:
>
> - pause for files to age for hashcache must now wait longer.
It's a shame to have tests that stop the test suite for 5 seconds. It always
feels like an unsatsifactory hack to me. Would it be better to directly update
the mtime of those files in the tests instead?
I guess the downside is that an "age_file" rather than "pause" function would
be slightly more complex (to implement, and to explain).
-Andrew.
More information about the bazaar
mailing list