[MERGE] test framework distinguishes skips

[John Arbash Meinel]

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Well, I'm actually more concerned that we will have a test which fails
>>> for the wrong reason, and gets skipped.
> 
> I think skips are a necessary evil, and that we should have a way to
> show all reasons for skipping, so we can catch such bogosities.  But I
> agree that we should try to avoid that kind of problem in the first place.
> 

Yeah, but since the pqm runs with LANG=C (make test), all unicode tests
are skipped. So I don't think we want to look through 200 skipped tests
to see that one was skipped for the wrong reason.

>>> But in
>>> general I thought a lot of things looked cleaner, but perhaps a little
>>> too clean for some things. (Like the unicode exception catching).
> 
> So I'm handling the platform stuff more conventionally now.
> 
> The updated test framework code reverts to the old way of handling
> unicode, except that it throws a particular subclass of TestSkipped.

Sounds good.

> 
> The symlink and file mode checks are done with TestCase.require_symlinks
> and TestCase.require_file_modes
> 
> Aaron

It seems reasonable to have those on TestCaseInTempDir, rather than
TestCase. Simply because you don't really require either one if you
aren't writing to the filesystem.

I'm okay with having them on TestCase, but just trying to keep things up
the stack as simple as possible.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060707/403490f4/attachment.pgp