[MERGE] test framework distinguishes skips

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jul 7 15:48:21 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Well, I'm actually more concerned that we will have a test which fails
> for the wrong reason, and gets skipped.

I think skips are a necessary evil, and that we should have a way to
show all reasons for skipping, so we can catch such bogosities.  But I
agree that we should try to avoid that kind of problem in the first place.

> But in
> general I thought a lot of things looked cleaner, but perhaps a little
> too clean for some things. (Like the unicode exception catching).

So I'm handling the platform stuff more conventionally now.

The updated test framework code reverts to the old way of handling
unicode, except that it throws a particular subclass of TestSkipped.

The symlink and file mode checks are done with TestCase.require_symlinks
and TestCase.require_file_modes

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFErnQ10F+nu1YWqI0RAtcQAJ9A/fCl41qEH/fst9+D5m9jPdngJQCeNjL6
fuWEkMq0eQ57z5KsHfQFUTk=
=zAOF
-----END PGP SIGNATURE-----




More information about the bazaar mailing list