Garbage in "bzr commit" output

John Arbash Meinel john at arbash-meinel.com
Fri Jul 7 15:40:08 BST 2006


Alexander Belchenko wrote:
> Matthieu Moy пишет:
>> For the commit interface, DVC (Emacs front-end) grabs the output of
>> "bzr commit" and displays it in a buffer.
>>
>> A few revisions ago, this used to display all the garbage due to the
>> progress-bar, but it seems bzr disabled the progress-bar probably
>> because it was not writting to a tty.
>>

...

> 
> I talk about this at least twice during last month. Sigh...
> 
> It's not only in commit output, but in diff also. And many many other
> commands too.

Sorry it took so long to get to. I only just started :) It has been in
my todo list, but getting the win32 tests passing was on a higher priority.

Anyway, while there I also found another bug when show_eta=False. Where
we actually would grow the last_updates() list without bound. Not a
huge, huge deal, since we generally only have a few thousand updates,
especially after throttling, but not correct either.

So the attached bundle fixes both cases.
1) Don't clear the terminal if there isn't anything to clear
2) Don't let self.last_updates() grow without bound. It defaults to
being capped at something higher than the default get_eta() cap. We can
make it whatever we want, I just want it capped at *some* value.

John
=:->
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cleanup-progress.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060707/5a2dcbe0/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060707/5a2dcbe0/attachment.pgp 


More information about the bazaar mailing list