[merge] bzr whoami

[Robey Pointer]

On 5 Jul 2006, at 2:38, Wouter van Heyst wrote:

> On Tue, Jul 04, 2006 at 06:27:57PM -0500, John Arbash Meinel wrote:
>
> ...
>
>>>>>> I think we may want to validate that the supplied value really  
>>>>>> is a:
>>>>>>
>>>>>> "Full Name <email at address.com>"
>>>>>>
>>>>>> Rather than just letting them do:
>>>>>>
>>>>>> bzr whoami george
>>>>>>
>>>>>> We do accept short names (I don't think we explicitly require  
>>>>>> email
>>>>>> addresses anywhere). But we would probably at least want to  
>>>>>> warn the
>>>>>> user that it is recommended to use a full email address, etc.

[...]

>> I'm not sure about this one. I'm thinking more that we should give a
>> warning/recommendation, but accept it if they don't want to use an  
>> email
>> address.
>>
>> What do other people think?
>
> Especially considering it will just be <username> for foreign svn
> branches, not accepting non-email seems wrong.

I made a patch to turn it into a warning, but it turns out that you  
can't commit with an identity that doesn't contain an email address.   
Given that behavior, does it make sense to allow one to be set  
through 'whoami'?  (You can always manually edit the config file.)

Also: Why doesn't warning() indicate that it's a warning?  I ended up  
trying:
	warning('warning: ' + str(e))
because it otherwise wasn't clear that the message was a warning and  
not an error.

robey