[merge] bzr whoami

[Wouter van Heyst]

On Tue, Jul 04, 2006 at 06:27:57PM -0500, John Arbash Meinel wrote:

...

> >>>> I think we may want to validate that the supplied value really is a:
> >>>>
> >>>> "Full Name <email at address.com>"
> >>>>
> >>>> Rather than just letting them do:
> >>>>
> >>>> bzr whoami george
> >>>>
> >>>> We do accept short names (I don't think we explicitly require email
> >>>> addresses anywhere). But we would probably at least want to warn the
> >>>> user that it is recommended to use a full email address, etc.
> >>>
> >>> I think that's a good idea.  I would want to just reuse the method that
> >>> does this extraction in config, so it should be a separate patch.
> >>
> >> Sure. I realize you have a branch for this, but is there any reason you
> >> didn't post a patch?
> > 
> > Sorry, I just wanted to get the patch landed.  I've had terrible luck in
> > the past with patches getting lost, either because of long, side-tracked
> > debates or just getting lost in the shuffle.
> > 
> > Also I thought it would be harder than it turned out to be.  I think the
> > tiny attached bundle is all that's required.  (It's also in my whoami
> > branch.)
> > 
> > robey
> > 
> 
> Your other branch has landed.
> 
> I'm not sure about this one. I'm thinking more that we should give a
> warning/recommendation, but accept it if they don't want to use an email
> address.
> 
> What do other people think?

Especially considering it will just be <username> for foreign svn
branches, not accepting non-email seems wrong.

Wouter van Heyst