nits about get_revisions...

[John Arbash Meinel]

Robert Collins wrote:
> Just a note, I think this stuff should have been caught by peer review:
> 
>                                                     self.get_transaction())[0]
>     @needs_read_lock
>     def get_revisions(self, revision_ids):
>         return self._revision_store.get_revisions(revision_ids,
>                                                   self.get_transaction())
> 
> 
> Hopefully that pasted correctly. Anyway:
>  - no docstring
>  - no vertical space between the previous function and this.

Well, the no-whitespace is hard to see, because of the lack of chars on
the previous line.
And it could have come in, on one of those 6k-line changes that don't
have quite as fine tooth comb as some.

But yes, both of those need to be fixed.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060705/060e4b71/attachment.pgp